Re: [PATCH 17/25] wm97xx: don't use [delayed_]work_pending()
From: Tejun Heo
Date: Mon Dec 24 2012 - 13:25:54 EST
Hello, Dmitry.
On Sun, Dec 23, 2012 at 01:54:50AM -0800, Dmitry Torokhov wrote:
> This is not 100% equivalent transformation as now we schedule first and
> disable IRQ later... Anyway, I think the driver shoudl be converted to
> threaded IRQ instead. Mark, does the patch below make any sense to you?
Yeah, I think the conversion is actually broken. There isn't anything
which prevents work item execution racing against irq disabling. I
agree the right thing to do is using threaded irq handler.
Thanks!
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/