Re: [PATCH 06/18] sched: set initial load avg of new forked task asits load weight

From: Alex Shi
Date: Sun Dec 23 2012 - 07:00:21 EST


>> update_curr(cfs_rq);
>> account_entity_enqueue(cfs_rq, se);
>> - enqueue_entity_load_avg(cfs_rq, se, flags & ENQUEUE_WAKEUP);
>> + enqueue_entity_load_avg(cfs_rq, se, flags &
>> + (ENQUEUE_WAKEUP | ENQUEUE_NEWTASK));
>
> It seems that just passing 'flags' is enough.

Uh, Yes, it's true. will remove this.
>
>>
>> if (flags & ENQUEUE_WAKEUP) {
>> place_entity(cfs_rq, se, 0);
>> @@ -2586,6 +2594,7 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
>> cfs_rq->h_nr_running++;
>>
>> flags = ENQUEUE_WAKEUP;
>> + flags &= ~ENQUEUE_NEWTASK;
>
> Why is this needed?

Uh. not needed, will remove this too. Thanks a lot!

--
Thanks
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/