Re: [PATCH 25/25] ipc: don't use [delayed_]work_pending()

From: Andrew Morton
Date: Fri Dec 21 2012 - 21:15:28 EST

On Fri, 21 Dec 2012 17:57:15 -0800 Tejun Heo <tj@xxxxxxxxxx> wrote:

> There's no need to test whether a (delayed) work item in pending
> before queueing, flushing or cancelling it. Most uses are unnecessary
> and quite a few of them are buggy.

> - if (!work_pending(&ipc_memory_wq))
> - schedule_work(&ipc_memory_wq);
> + schedule_work(&ipc_memory_wq);

Well, the new code is a ton slower than the old code if the work is
frequently pending, so some care is needed with such a conversion.

That's not an issue for the IPC callsite - memory offlining isn't

> ...
> Please let me know how this patch should be routed. I can take it
> through the workqueue tree if necessary.

Please merge this one yourself.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at