Re: [RFCv2 07/11] remoteproc: Register virtio devices after vring allocation

From: Ohad Ben-Cohen
Date: Fri Dec 21 2012 - 10:32:50 EST


Hi Sjur,

On Fri, Dec 21, 2012 at 3:50 PM, Sjur BRENDELAND
<sjur.brandeland@xxxxxxxxxxxxxx> wrote:
> Yes, but I think this will work if we allocate resources first,
> and then in the next step register the virtio devices.
> All the resources for all the vdevs will be allocated first
> and then rproc_boot will be called.

This sounds similar to what we had originally, before commit 6db20ea
"remoteproc: allocate vrings on demand, free when not needed". We can
revert this, but we then lose the properties 6db20ea provided.

Will Ido's suggestion to count the number of notifiyids in advance
work for you? at foresight it sounds like it could be just a few lines
of code, with no real hit on performance.

Thanks and happy holidays!
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/