Re: [PATCH] sched/rt: Move cpu rq properties from "struct rt_rq" to"struct rq"

[Steven Rostedt]

On Fri, 2012-12-21 at 02:16 +0400, Kirill Tkhai wrote:
> 20.12.2012, 21:53, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx>:
> > On Tue, 18 Dec 2012, Kirill Tkhai wrote:
> >
> >>  The members rt_nr_total, rt_nr_migratory, overloaded and pushable_tasks are
> >>  properties of cpu runqueue, not group rt_rq.
> >
> > Why?
> 
> Because, they depend on number and properties of all processes of rq, not of nested rt_rq.
> 

You're answer is still confusing.

	struct rq {
		[...]
		struct rt_rq rt;


rt_rq is just a part of rq. What's the point?

	rq = container_of(rt_rq, struct rt_rq, rt);

As the comment above struct rt_rq says:

/* Real-Time classes' related field in a runqueue: */

Those look like fields related to the Real-Time class. I don't see them
used outside of kernel/sched/rt.c

-- Steve

> >
> > Thanks,
> >
> >         tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/