Re: [PATCH] mm: compaction: Do not accidentally skip pageblocks inthe migrate scanner

[Rik van Riel]

On 12/20/2012 09:22 AM, Mel Gorman wrote:
> Compaction uses the ALIGN macro incorrectly with the migrate scanner by
> adding pageblock_nr_pages to a PFN. It happened to work when initially
> implemented as the starting PFN was also aligned but with caching restarts
> and isolating in smaller chunks this is no longer always true. The impact is
> that the migrate scanner scans outside its current pageblock. As pfn_valid()
> is still checked properly it does not cause any failure and the impact
> of the bug is that in some cases it will scan more than necessary when
> it crosses a page boundary but by no more than COMPACT_CLUSTER_MAX. It
> is highly unlikely this is even measurable but it's still wrong so this
> patch addresses the problem.
>
> Signed-off-by: Mel Gorman <mgorman@xxxxxxx>

Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/