RE: [PATCH] n_gsm.c: add tx_lock in gsm_send

[Xiao, Jin]

Alan, 

Thanks. But the comment makes me confused. As we see, gsm->output is called by gsm_data_kick too, and it's in the tx_lock...

Best regards,
Jin Xiao


> From: xiaojin <jin.xiao@xxxxxxxxx>
> Date: Wed, 19 Dec 2012 11:53:43 +0800
> Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send
> 
> All the call to gsm->output should be in the tx_lock, that could avoid 
> potential race from MUX level. But we have no tx_lock in gsm_send.
> 
> This patch is to add tx_lock in gsm_send.

gsm->output calls the transmit method of the underlying tty driver. We
can't do that with interrupts off as some drivers expect to be able to sleep in their output paths.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/