Re: [PATCH] gpio: samsung: remove exynos_gpio_cfg

From: Joonyoung Shim
Date: Wed Dec 19 2012 - 20:13:33 EST

Hi Grant,

On 12/20/2012 07:22 AM, Grant Likely wrote:
On Fri, 14 Dec 2012 19:44:01 +0900, Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> wrote:
The exynos_gpio_cfg can be substituted to samsung_gpio_cfgs[8].

Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
Hi Joonyoung,

I need some help here. I don't understand what this patch is for or how
it works. The commit text above doesn't give me enough information to
evaluate the patch. What is the intent here? Why is samsung_gpio_cfgs[8]
more correct than exynos_gpio_cfg?

First, i just wondered why samsung_gpio_cfgs[8] is used in the
exynos4_gpios_2[] even if exynos_gpio_cfg is exist and found
samsung_gpio_cfgs[8] does same thing with exynos_gpio_cfg. The
exynos_gpio_cfg is used only for Exynos SoCs so it is compiled by #if
I think one can be removed because they are duplicated codes and it is
better to decrease use of #if defined.



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at