Re: [PATCH v2] backlight: add lms501kf03 LCD driver

From: Andrew Morton
Date: Wed Dec 19 2012 - 18:07:12 EST


On Tue, 18 Dec 2012 17:46:46 +0900
Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:

> Add the lms501kf03 LCD panel driver. The lms501kf03 LCD panel (800
> x 480) driver uses 3-wired SPI inteface.

Looks OK.

> +static unsigned int before_power;

This is unused. Can I zap it?


--- a/drivers/video/backlight/lms501kf03.c~backlight-add-lms501kf03-lcd-driver-fix
+++ a/drivers/video/backlight/lms501kf03.c
@@ -388,7 +388,6 @@ static int lms501kf03_remove(struct spi_
}

#if defined(CONFIG_PM)
-static unsigned int before_power;

static int lms501kf03_suspend(struct spi_device *spi, pm_message_t mesg)
{
@@ -396,8 +395,6 @@ static int lms501kf03_suspend(struct spi

dev_dbg(&spi->dev, "lcd->power = %d\n", lcd->power);

- before_power = lcd->power;
-
/*
* when lcd panel is suspend, lcd panel becomes off
* regardless of status.
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/