Re: [PATCH v6 03/27] x86, boot: move verify_cpu.S and no_longmodeafter 0x200

From: Borislav Petkov
Date: Wed Dec 19 2012 - 17:04:39 EST


On Wed, Dec 19, 2012 at 01:58:57PM -0800, Yinghai Lu wrote:
> On Wed, Dec 19, 2012 at 12:57 PM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> > On Tue, Dec 18, 2012 at 07:44:55PM -0800, Yinghai Lu wrote:
> >
> > So this explains what you're doing but I'd like to know why?
> >
> > Why do you need to free some more room between startup_32 and
> > startup_64? Do you need this room in another patch, maybe the next one:
> >
> > "[PATCH v7 14/27] x86, boot: Move lldt/ltr out of 64bit code section"
> >
> > Is that so? If yes, please write that in the commit message so that we
> > know why you're doing that change.
>
> duplicate next patch commit log here. no, that's too long.

Sorry, I'm not suggesting to duplicate the patch commit log here -
simply say instead:

"We are short of space before address 0x200 which is the 64-bit entry
point (startup_64). Since we're going to need that space in the next
patch, and, according to hpa, startup_64 has become an ABI and thus
cannot be moved, move function verify_cpu and no_longmode further down."

See, clear and simple.

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/