Re: [RFC PATCH 1/5] ARM: remove useless guard in smp.c
From: Mark Rutland
Date: Wed Dec 19 2012 - 04:40:18 EST
On Tue, Dec 18, 2012 at 06:47:09PM +0000, Stephen Boyd wrote:
> On 12/18/12 04:06, Mark Rutland wrote:
> > Currently we only provide an implementation of smp_timer_broadcast in
> > smp.c if GENERIC_CLOCKEVENTS_BROADCAST is selected. As
> > smp_timer_broadcast is only used in smp.c, smp.c depends on SMP, and
> > GENERIC_CLOCKEVENTS_BROADCAST is selected by SMP, this is unnecessary.
>
> You might want to add that GENERIC_CLOCKEVENTS_BROADCAST depends on
> GENERIC_CLOCKEVENTS and SMP depends on GENERIC_CLOCKEVENTS too.
Will do.
> > This patch removes the redundant guard.
> >
> > Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx>
>
> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
Thanks!
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/