Re: [PATCH v3 08/10] x86/head64.c: Early update ucode in 64-bit

[Yinghai Lu]

On Tue, Dec 18, 2012 at 2:55 PM, Yu, Fenghua <fenghua.yu@xxxxxxxxx> wrote:
>> From: yhlu.kernel@xxxxxxxxx [mailto:yhlu.kernel@xxxxxxxxx] On Behalf Of
>> Yinghai Lu
>> On Mon, Dec 17, 2012 at 3:30 PM, Yu, Fenghua <fenghua.yu@xxxxxxxxx>
>> wrote:
>> >
>> > OSV may need the patchset based on old kernel. So I'll have the
>> patchset ready. Is this the right place to call load_ucode_bsp() in the
>> upstream kernel?
>> >
>> > diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
>> > index a512f56..e94b90e 100644
>> > --- a/arch/x86/kernel/head64.c
>> > +++ b/arch/x86/kernel/head64.c
>> > @@ -93,6 +88,11 @@ void __init x86_64_start_kernel(char *
>> real_mode_data)
>> >         }
>> >         load_idt((const struct desc_ptr *)&idt_descr);
>> >
>> > +       /*
>> > +        * Load microcode early on BSP.
>> > +        */
>> > +       load_ucode_bsp(__va(real_mode_data));
>> > +
>> >         if (console_loglevel == 10)
>> >                 early_printk("Kernel alive\n");
>> >
>> it has to be after #PF handler set page table patch...
>>
>> otherwise when ramdisk is above 1G, customer will get early PF
>> exception.
>
> If based on your for_x86_boot tree, is load_ucode_bsp() called afer load_idt()?
>

yes.

Please do try your patches on system with more than 4G ram.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/