Re: [PATCH] checkpatch: Warn on #include <uapi/...

[David Howells]

Joe Perches <joe@xxxxxxxxxxx> wrote:

> +			if ($path =~ "^uapi/") {
> +				ERROR("UAPI_INCLUDE",
> +				      "#include should not start with uapi/\n" . $herecurr);
>  			}

But does this limit the check only to headers in uapi/ directories?  You need
to be able to do this outside of a uapi/ directory.  For instance,
include/linux/fs.h shadows include/uapi/linux/fs.h and so the former has to
#include the latter directly as <uapi/linux/fs.h> or else suffer a circular
link.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/