Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage ofIS_ERR_OR_NULL

From: Tony Prisk
Date: Tue Dec 18 2012 - 13:52:26 EST

On Tue, 2012-12-18 at 21:39 +0300, Dan Carpenter wrote:
> On Wed, Dec 19, 2012 at 06:34:05AM +1300, Tony Prisk wrote:
> > Resend to include mailing lists.
> >
> > Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
> >
> The original code is correct. clk_get() can return NULL depending
> on the .config.
> regards,
> dan carpenter

Thanks for than Dan,

Arguably that seems like an incorrect behaviour on the part of the clock
subsystem given that the 'proper' function has kernel doc:

* Returns a struct clk corresponding to the clock producer, or
* valid IS_ERR() condition containing errno.

Therefore the 'empty' version should adhere to the same rules, and not
return NULL.

I've cc'd Mike Turquette as well for his thoughts.

Tony P

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at