Re: [PATCH] usb: host: tegra: make use of PHY pointer of HCD

From: Alan Stern
Date: Tue Dec 18 2012 - 11:05:33 EST


On Tue, 18 Dec 2012, Venu Byravarasu wrote:

> As pointer to PHY structure can be stored in struct usb_hcd
> making use of it, to call PHY APIs.
>
> Call to usb_phy_shutdown() is moved up in tegra_ehci_remove(),
> so that to avoid dereferencing of hcd after its freed up.
>
> Signed-off-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx>
> ---
> This patch depends on patch http://marc.info/?l=linux-kernel&m=135581274019690&w=2.
> Without above patch applied, phy->notify_connect & phy->notify_disconnect are
> set to some unknown values, which need not be NULL.
> This creates problem when hcd->phy pointer is initialized hub_port_init() in hub.c
> calls usb_phy_notify_connect().
>
> Stephen,
> Can you plz take this patch through tegra tree, so as to take care of the dependencies?

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/