Re: [PATCH] spi: Add the flag indicate to registe new device aschildren of master or not.

From: Mark Brown
Date: Tue Dec 18 2012 - 10:26:18 EST

On Tue, Dec 18, 2012 at 11:29:34AM -0500, Jun Chen wrote:

> * @master: Controller to which device is connected
> + * device_was_children_of_master is flag which the device is registed
> + * as the children of the bus

This isn't a kerneldoc style comment (it needs the @XXX: format). The
name is also extremely long, can't we think of something more concise?

> - spi->dev.parent = &master->dev;
> + if (device_was_children_of_master == true)
> + spi->dev.parent = &master->dev;
> + else
> + spi->dev.parent = dev;

Can you provide an example of where this is useful? Your changelog
didn't make it clear and the code doesn't make it obvious either.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at