checkpatch.pl should check UAPI headers don't #include <uapi/...>
From: David Howells
Date: Tue Dec 18 2012 - 09:24:04 EST
Hi Joe,
Can you make checkpatch.pl check that lines added to UAPI headers don't have
the form:
#include <uapi/...>
or:
#include "uapi/..."
Such as these should be regarded as errors as they will likely break userspace
which shouldn't get to see any uapi/ directories.
An example of this is in:
commit 19bf7f8ac3f8131100027281c495dbbe00cd5ae0
Merge: 787c57c 35fd3dc
Author: Marcelo Tosatti <mtosatti@xxxxxxxxxx>
Date: Mon Oct 29 19:15:32 2012 -0200
where during the conflict resolution, the following change was made:
- #include <asm/epapr_hcalls.h>
++#include <uapi/asm/epapr_hcalls.h>
I recognise that checkpatch.pl might not have helped in this case since it
isn't normally applied to merged as far as I know.
Thanks,
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/