Re: [PATCH] sched: numa: Fix build error if CONFIG_NUMA_BALANCING&& !CONFIG_TRANSPARENT_HUGEPAGE

From: David Rientjes
Date: Tue Dec 18 2012 - 02:55:39 EST


On Mon, 17 Dec 2012, Mel Gorman wrote:

> Michal Hocko reported that the following build error occurs if
> CONFIG_NUMA_BALANCING is set without THP support
>
> kernel/sched/fair.c: In function â??task_numa_workâ??:
> kernel/sched/fair.c:932:55: error: call to â??__build_bug_failedâ?? declared with attribute error: BUILD_BUG failed
>
> The problem is that HPAGE_PMD_SHIFT triggers a BUILD_BUG() on
> !CONFIG_TRANSPARENT_HUGEPAGE. This patch addresses the problem.
>
> Reported-by: Michal Hocko <mhocko@xxxxxxx>
> Signed-off-by: Mel Gorman <mgorman@xxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

Fixes the build issue for me, thanks.