Re: [tip:x86/microcode] x86/microcode_intel_early.c: Early updateucode on Intel's CPU

[H. Peter Anvin]

On 12/17/2012 02:47 PM, Yinghai Lu wrote:
> Peter, can you check that branch again?
>
> I moved the early_trap_init after init_mem_mapping.
> so for 64bit native, init_mem_mapping will setup page table for ram from blank.

Looks better, at first glance at least.  There are a couple of 
unnecessary changes (the counter in head_64.S cannot exceed 32 bits once 
computed, so the change from %rcx to %ecx change is pointless.)

There is another bug in my patch: it either needs to mask off the NX bit 
if we are running on non-NX-enabled hardware, or it needs to not set the 
NX bit (which is mostly okay that early on, I suspect.)

	-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/