Re: [PATCH 1/9] can: add tx/rx LED trigger support

From: "Bernd Krumböck"
Date: Mon Dec 17 2012 - 15:20:57 EST

> Hi Bernd,
> On Mon, Dec 17, 2012 at 08:28:48AM +0100, Bernd Krumboeck wrote:
>> Why there is no patch for any usb can device?
> Because USB canbus interfaces usually already has some dedicated
> activity LED on the device itself, while this patch is meant to give an
> equivalent functionality for Embedded SoC with GPIO based LEDs, so I
> just started by modifying some Embedded CAN drivers.
> If you think it's useful for USB controller, just tell me or modify the
> driver by yourself! As you see the patch is really easy.

At least it is useful for the usb_8dev driver. I'll write a patch.

Photo of the device:

>> Can this be done in a more general way, except patching every driver?
> Actually this started as a generic patch bolted to the CAN stack, but
> the implementation was too invasive and a bit too hacky. A generic
> implementation at can-dev level is hard to obtain because the can-dev
> layer is not used in all the device operation, as the most of the driver
> calls generick network API directly.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at