Re: [PATCH 2/5] arcmsr: Support Hibernation

[James Bottomley]

On Tue, 2012-12-04 at 19:59 +0800, NickCheng wrote:
> From: Nick Cheng <nick.cheng@xxxxxxxxxxxx>
> 
> Support hibernation for whole series of RAID controllers

This doesn't compile:

  CC [M]  drivers/scsi/arcmsr/arcmsr_hba.o
drivers/scsi/arcmsr/arcmsr_hba.c: In function âarcmsr_iop_message_xferâ:
drivers/scsi/arcmsr/arcmsr_hba.c:1871:36: error: âKM_IRQ0â undeclared (first use in this function)
drivers/scsi/arcmsr/arcmsr_hba.c:1871:36: note: each undeclared identifier is reported only once for each function it appears in
drivers/scsi/arcmsr/arcmsr_hba.c:1871:2: error: too many arguments to function âkmap_atomicâ
In file included from include/linux/pagemap.h:10:0,
                 from include/linux/blkdev.h:13,
                 from include/scsi/scsi_cmnd.h:5,
                 from drivers/scsi/arcmsr/arcmsr_hba.c:67:
include/linux/highmem.h:66:21: note: declared here
drivers/scsi/arcmsr/arcmsr_hba.c:2127:44: error: macro "kunmap_atomic" passed 2 arguments, but takes just 1
drivers/scsi/arcmsr/arcmsr_hba.c:2127:2: error: âkunmap_atomicâ undeclared (first use in this function)
drivers/scsi/arcmsr/arcmsr_hba.c: In function âarcmsr_handle_virtual_commandâ:
drivers/scsi/arcmsr/arcmsr_hba.c:2180:37: error: âKM_IRQ0â undeclared (first use in this function)
drivers/scsi/arcmsr/arcmsr_hba.c:2180:3: error: too many arguments to function âkmap_atomicâ
In file included from include/linux/pagemap.h:10:0,
                 from include/linux/blkdev.h:13,
                 from include/scsi/scsi_cmnd.h:5,
                 from drivers/scsi/arcmsr/arcmsr_hba.c:67:
include/linux/highmem.h:66:21: note: declared here
drivers/scsi/arcmsr/arcmsr_hba.c:2184:45: error: macro "kunmap_atomic" passed 2 arguments, but takes just 1
drivers/scsi/arcmsr/arcmsr_hba.c:2184:3: error: âkunmap_atomicâ undeclared (first use in this function)
make[3]: *** [drivers/scsi/arcmsr/arcmsr_hba.o] Error 1

And that's because you're using an ancient form of kmap_atomic() which
was deprecated by

commit 3e4d3af501cccdc8a8cca41bdbe57d54ad7e7e73
Author: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Date:   Tue Oct 26 14:21:51 2010 -0700

    mm: stack based kmap_atomic()

And actually made unsupported a year ago.  What are you compile testing
this against?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/