Re: [PATCH v3 04/10] x86/microcode_core_early.c: Define interfacesfor early loading ucode

[Borislav Petkov]

On Sun, Dec 16, 2012 at 06:09:12PM +0000, Yu, Fenghua wrote:
> Nothing wrong with taking the parameters. But CPUID_IS is only limited
> in this file. There is no other places to use it. I think either way
> is ok.

Please don't do this. Anything can happen, someone can copy it somewhere
else and try to use it, unification, code movement can all of a sudden
break things in the most mysterious ways.

However, if you make the macro definition self-contained. none of those
issues will happen.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/