[PATCH 07/21] gpio: ab8500: Write argument value instead of hardwired 1

From: Lee Jones
Date: Fri Dec 14 2012 - 11:22:40 EST


From: Marcel Tunnissen <Marcel.Tuennissen@xxxxxxxxxxxxxx>

This fixes a bug in gpio_set_value(xxx, 0) for ab8500 GPIOs.

Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
Signed-off-by: Marcel Tunnissen <Marcel.Tuennissen@xxxxxxxxxxxxxx>
Reviewed-by: Jonas ABERG <jonas.aberg@xxxxxxxxxxxxxx>
Tested-by: Jonas ABERG <jonas.aberg@xxxxxxxxxxxxxx>
---
drivers/gpio/gpio-ab8500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-ab8500.c b/drivers/gpio/gpio-ab8500.c
index b71bb72..d3bbcce 100644
--- a/drivers/gpio/gpio-ab8500.c
+++ b/drivers/gpio/gpio-ab8500.c
@@ -132,7 +132,7 @@ static void ab8500_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
struct ab8500_gpio *ab8500_gpio = to_ab8500_gpio(chip);
int ret;
/* Write the data */
- ret = ab8500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, 1);
+ ret = ab8500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val);
if (ret < 0)
dev_err(ab8500_gpio->dev, "%s write failed\n", __func__);
}
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/