Re: [patch 3/8] mm: vmscan: save work scanning (almost) empty LRUlists

From: Mel Gorman
Date: Thu Dec 13 2012 - 05:40:56 EST


On Wed, Dec 12, 2012 at 04:43:35PM -0500, Johannes Weiner wrote:
> In certain cases (kswapd reclaim, memcg target reclaim), a fixed
> minimum amount of pages is scanned from the LRU lists on each
> iteration, to make progress.
>
> Do not make this minimum bigger than the respective LRU list size,
> however, and save some busy work trying to isolate and reclaim pages
> that are not there.
>
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>

This looks like a corner case where the LRU size would have to be smaller
than SWAP_CLUSTER_MAX. Is that common enough to care? It looks correct,
I'm just curious.

Acked-by: Mel Gorman <mgorman@xxxxxxx>

--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/