Re: [RFC/RFT][PATCH 1/4] regulator: core: Allow specifyactivate_[reg|bit] for regmap based voltage_sel operations

From: Mark Brown
Date: Thu Dec 13 2012 - 03:48:28 EST


On Thu, Dec 13, 2012 at 04:44:08PM +0800, Axel Lin wrote:
> Some DVM regulators needs to update activate_bit after setting vsel_reg to
> initiate voltage change on the output. This patch adds activate_reg and
> activate_bit to struct regulator_desc and update
> regulator_set_voltage_sel_regmap() to set activate_bit of activate_reg when
> activate_bit is set.

I'm not convinced about the naming here... how about apply rather than
activate? Not sure if it shouldn't be specific to voltage setting
either.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/