Re: [Patch v3 3/7] rtc: DA9055 RTC driver

From: Ashish Jangam
Date: Thu Dec 13 2012 - 00:54:29 EST


On Wed, 2012-12-12 at 13:11 -0800, Andrew Morton wrote:
> On Mon, 10 Dec 2012 11:12:29 +0530
> Ashish Jangam <ashish.jangam@xxxxxxxxxxxxxxx> wrote:
>
> > On Wed, 2012-11-28 at 14:54 +0530, Ashish Jangam wrote:
> > > On Tue, 2012-11-27 at 14:23 -0800, Andrew Morton wrote:
> > > > On Fri, 23 Nov 2012 15:41:03 +0530
> > > > Ashish Jangam <ashish.jangam@xxxxxxxxxxxxxxx> wrote:
> > > >
> > > > > On Tue, 2012-10-23 at 15:33 +0530, Ashish Jangam wrote:
> > > > > > Does this patch looks good?
> > > > > > On Thu, 2012-10-11 at 16:10 +0530, Ashish Jangam wrote:
> > > > > > > This is the RTC patch for the DA9055 PMIC. This patch has got dependency on
> > > > > > > the DA9055 MFD core.
> > > > > > >
> > > > > > > This patch is functionally tested on Samsung SMDKV6410.
> > > >
> > > > "shubhro <omaplinuxkernel@xxxxxxxxx>" made a comment, but it was ignored:
> > > >
> > > > : On Thu, 11 Oct 2012 16:53:34 +0530
> > > > : shubhro <omaplinuxkernel@xxxxxxxxx> wrote:
> > > > :
> > > > : > On Thursday 11 October 2012 04:10 PM, Ashish Jangam wrote:
> > > > : > > +#define da9055_rtc_freeze NULL
> > > > : > > +#endif
> > > > : > > +
> > > > : > > +static const struct dev_pm_ops da9055_rtc_pm_ops = {
> > > > : > > + .suspend = da9055_rtc_suspend,
> > > > : > > + .resume = da9055_rtc_resume,
> > > > : > > +
> > > > : > > + .freeze = da9055_rtc_freeze,
> > > > : > > + .thaw = da9055_rtc_resume,
> > > > : > > + .restore = da9055_rtc_resume,
> > > > : > > +
> > > > : > > + .poweroff = da9055_rtc_suspend,
> > > > : > > +};
> > > > : > You may want to use simple dev pm ops
> > > To support generic PM ops these additional ops were supported.
> > Are there any further comments on this patch.
>
> Is the patch usable against current mainline? "This patch has got
> dependency on the DA9055 MFD core". What is the status of that?
The dependent DA9055 MFD core is merged.
>
> If the patch is ready to go then please refresh it, retest and resend?
>
Ok, I can test and resend it.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/