Re: [RFC PATCH 2/3] regulator: max77686: Add support for variousoperating modes

From: Abhilash Kesavan
Date: Tue Dec 11 2012 - 22:05:09 EST


On Tue, Dec 11, 2012 at 6:27 PM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote:
>> On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan
>> <kesavan.abhilash@xxxxxxxxx> wrote:
>
>> > Mark Brown <broonie <at> opensource.wolfsonmicro.com> writes:
>
>> >> Binding documenation is mandatory for any new OF properties, please add
>> >> this.
>
>> > Patch 3/3 of this series adds documentation for the max77686-opmode property.
>
> There is no point in splitting changes like this up, it just makes
> review harder - in this case it caused me to not read your patch due
> to the missing documentation. Put the whole change together unless
> things are getting too big to review.
OK.

Can you please have a look at Doug's proposal for handling the
operating mode generically in patch 3/3 of this series.
If you are OK with it then I'll start work on implementing it.

Thanks,
Abhilash
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/