Re: [PATCH 3/3 v2] iio: add rtc-driver for HID sensors of type time

[Alexander Holler]

Am 10.12.2012 23:36, schrieb Lars-Peter Clausen:
> Well, I've been exaggerating a bit, you can call it multiple times, but you

Thanks a lot for the explanation(s).

> > > > +error_free_drvdata:
> > > > +    platform_set_drvdata(pdev, NULL);
> > >
> > > Setting the platform data to NULL should not be necessary. Some
> > > drivers do
> > > this but it's kind of the result of cargo-cult-coding.
> > >
> > > > +    kfree(time_state);

Btw. I wouldn't call that cargo-cult-coding. It's more defensive 
programming as people might not be sure, if there is something around 
which still might access the platform data at that point. Ok, there 
would be a need for a mutex or similiar if that really could happen, but 
I wouldn't call such practices cargo-cult. ;)

Regards,

Alexander

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/