Re: IRQ subsystem menu

[Grant Likely]

On Wed, 5 Dec 2012 21:16:20 -0500, Paul Thompson <set48035@xxxxxxxxx> wrote:
> Grant Likely <grant.likely@xxxxxxxxxxxx>, on Thu  2012.11.29 said:
> > On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek <mmarek@xxxxxxx> wrote:
> > > (Adding lkml and Thomas as IRQ subsystem maintainer to CC)
> > > 
> > > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote:
> > > > 	Hi;
> > > > 
> > > > 	In menuconfig, General setup -> IRQ subsystem, there are two
> > > > possible menu-items. One depends partly on IRQ_DOMAIN, and the other
> > > > on MAY_HAVE_SPARSE_IRQ.
> > > > 
> [...]
> > > > 
> > > > 	Ideally, the "IRQ subsystem" menu would not even show up
> > > > if it would contain no menu-items, but I do not know enough to
> > > > formulate that constraint.
> > 
> > First, move the 'menu "IRQ subsystem"' line does to right before the
> > IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you
> > can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right
> > below the menu item.
> > 
> > You'll also need to move the IRQ_FORCED_THREADING line out from inside
> > the menu block.
> > 
> > Try it out and let me know how it goes.
> > 
> > g.
> 
> 	Hi;
> 
> 	The logic makes sense to me, and makes the menus appearance
> dependent on if either option setting can exist. So, on my system,
> the IRQ subsystem menu does not appear.
> 
> Paul

Looks right to me. Please repost with a proper commit log and
"Signed-off-by" line and I'll apply this patch.
(See Documentation/SubmittingPatches)

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/