Re: [PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl_ids

From: Grant Likely
Date: Mon Dec 10 2012 - 17:29:47 EST


On Mon, 10 Dec 2012 11:13:06 +0100, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Mon, Dec 10, 2012 at 2:35 AM, Axel Lin <axel.lin@xxxxxxxxxx> wrote:
>
> > The of_device_id table is supposed to be zero-terminated.
> >
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> > ---
> > drivers/gpio/gpio-samsung.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> > index 01f7fe9..9e251be 100644
> > --- a/drivers/gpio/gpio-samsung.c
> > +++ b/drivers/gpio/gpio-samsung.c
> > @@ -3026,6 +3026,7 @@ static __init int samsung_gpiolib_init(void)
> > static const struct of_device_id exynos_pinctrl_ids[] = {
> > { .compatible = "samsung,pinctrl-exynos4210", },
> > { .compatible = "samsung,pinctrl-exynos4x12", },
> > + { }
>
> Wasn't somebody complaining that this was unnecessary recently?
>
> Ohwell, I'll let the Samsung people comment first...

And this doesn't apply on my gpio/next branch. I assume it applies
somewhere else so I'll ignore for now. :-)

Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/