Re: [ 67/89] drm/radeon: properly track the crtc not_enabled caseevergreen_mc_stop()

From: Ben Hutchings
Date: Sun Dec 09 2012 - 18:26:02 EST


On Mon, 2012-12-03 at 15:35 +0000, Deucher, Alexander wrote:
> > -----Original Message-----
> > From: Josh Boyer [mailto:jwboyer@xxxxxxxxx]
> > Sent: Monday, December 03, 2012 10:25 AM
> > To: Ben Hutchings; Greg KH
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; akpm@linux-
> > foundation.org; alan@xxxxxxxxxxxxxxxxxxx; Deucher, Alexander
> > Subject: Re: [ 67/89] drm/radeon: properly track the crtc not_enabled case
> > evergreen_mc_stop()
> >
> > On Mon, Dec 3, 2012 at 9:32 AM, Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > wrote:
> > > 3.2-stable review patch. If anyone has any objections, please let me know.
> > >
> > > ------------------
> > >
> > > From: Alex Deucher <alexander.deucher@xxxxxxx>
> > >
> > > commit 804cc4a0ad3a896ca295f771a28c6eb36ced7903 upstream.
> > >
> > > The save struct is not initialized previously so explicitly
> > > mark the crtcs as not used when they are not in use.
> > >
> > > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> > > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> >
> > Hm. If this is needed in 3.2, presumably it's needed in 3.6 as well. I
> > don't see it queued for 3.6.9, and the Cc: tag is there.
> >
> > Greg, Alex, was this just something that was missed, or am I wrong about
> > it needing to go into 3.6?
>
> The original patches should go into 3.6 kernels as well:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=4a15903db02026728d0cf2755c6fabae16b8db6a
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=62444b7462a2b98bc78d68736c03a7c4e66ba7e2
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=804cc4a0ad3a896ca295f771a28c6eb36ced7903
>
> I've been meaning to follow up on it, but I haven't had the time. Do
> I need to send explicit patches to stable@vger or can I just ask the
> above commits be cherrypicked to 3.6?

It depends on whether they *can* be cleanly cherry-picked. You'll
presumably want them applied to all of 3.4, 3.5 and 3.6.

Ben.

--
Ben Hutchings
It is impossible to make anything foolproof because fools are so ingenious.

Attachment: signature.asc
Description: This is a digitally signed message part