Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

From: David Howells
Date: Tue Dec 04 2012 - 13:18:04 EST


Michal Marek <mmarek@xxxxxxx> wrote:

> Using the asm .incbin statement in C sources breaks any gcc wrapper which
> assumes that preprocessed C source is self-contained. Use a separate .S
> file to include the siging key and certificate.

I was trying to avoid that as .S files generally don't crop up in generic
code and the format of the assembly varies with the arch. However, you don't
seem to have anything that should cause a problem - so:

Acked-by: David Howells <dhowells@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/