Re: [PATCH] memory: of_memory.c: remove unnecessary initialization

From: Grant Likely
Date: Tue Dec 04 2012 - 08:55:28 EST


On Tue, Dec 4, 2012 at 11:44 AM, Santosh Shilimkar
<santosh.shilimkar@xxxxxx> wrote:
> On Tuesday 04 December 2012 04:56 PM, Cong Ding wrote:
>>
>> the initialization of variable ret is unnecessary, we can remove it while
>> save
>> one time "or" operation.
>>
>> Signed-off-by: Cong Ding <dinggnu@xxxxxxxxx>
>> ---
>
> Looks ok.
> Acked-by: Santosh Shilimkar<santosh.shilimkar@xxxxxx>
>

Thanks for the patch, but I don't think it matters enough to apply it.
The existing code isn't wrong.

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/