Re: [PATCH v5 8/8] Documentation: update nfs option in filesystem/vfat.txt

From: Namjae Jeon
Date: Tue Dec 04 2012 - 01:24:27 EST


2012/12/3, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>:
> Namjae Jeon <linkinjeon@xxxxxxxxx> writes:
>
>> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
>>
>> update nfs option in filesystem/vfat.txt
>>
>> Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
>> Signed-off-by: Ravishankar N <ravi.n1@xxxxxxxxxxx>
>> Signed-off-by: Amit Sahrawat <a.sahrawat@xxxxxxxxxxx>
>> ---
>> Documentation/filesystems/vfat.txt | 23 ++++++++++++++++++-----
>> 1 file changed, 18 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/filesystems/vfat.txt
>> b/Documentation/filesystems/vfat.txt
>> index d230dd9..f663c70 100644
>> --- a/Documentation/filesystems/vfat.txt
>> +++ b/Documentation/filesystems/vfat.txt
>> @@ -150,13 +150,26 @@ discard -- If set, issues discard/TRIM
>> commands to the block
>> device when blocks are freed. This is useful for SSD devices
>> and sparse/thinly-provisoned LUNs.
>>
>> -nfs -- This option maintains an index (cache) of directory
>> - inodes by i_logstart which is used by the nfs-related code to
>> - improve look-ups.
>> -
>> - Enable this only if you want to export the FAT filesystem
>> +nfs= stale_rw|nostale_ro
>> + -- Enable this only if you want to export the FAT filesystem
>> over NFS
>>
>> + stale_rw:This option maintains an index (cache) of directory
>> + inodes by i_logstart which is used by the nfs-related code to
>> + improve look-ups.Full file operations (read/write) over NFS is
>> supported
>> + but with cache eviction at NFS server, this could result in ESTALE
>> issues.
>> +
>> + nostale_ro:This option bases the inode number and filehandle on the
>> on-disk
>> + location of a file in the MS-DOS directory entry.This ensures that
>> ESTALE
>> + will not be returned after a file is evicted from the inode cache.
>> However,
>> + it means that operations such as rename, create and unlink could
>> cause
>> + filehandles that previously pointed at one file to point at a
>> different file,
>> + potentially causing data corruption. For this reason, this option also
>> mounts
>> + the filesystem readonly.
>> +
>> + To maintain backward compatibility, '-o nfs' is also accepted,
>> defaulting to
>> + stale_rw
>
> Please add whitespace after ":" and ".". And please care 80 columns.
Okay, I will fix it.
Thanks.
> --
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/