Re: [PATCH] block: Restore /proc/partitions to not displaynon-partitionable removable devices

From: Andrew Morton
Date: Mon Dec 03 2012 - 19:06:39 EST


On Mon, 19 Nov 2012 18:56:49 -0800
Josh Hunt <johunt@xxxxxxxxxx> wrote:

> We found with newer kernels we started seeing the cdrom device showing
> up in /proc/partitions, but it was not there before. Looking into this I found
> that commit d27769ec... block: add GENHD_FL_NO_PART_SCAN introduces this change
> in behavior. It's not clear to me from the commit's changelog if this change was
> intentional or not. This comment still remains:
> /* Don't show non-partitionable removeable devices or empty devices */
> so I've decided to send a patch to restore the behavior of not printing
> unpartitionable removable devices.

d27769ec was merged in August 2011, so I after all this time, your fix
could be viewed as "changing existing behaviour".

So perhaps it would be best to leave things alone. Is there any
particular problem with the post-Aug, 2011 behaviour?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/