What is the user/kernel interface for this driver? Is it documentedThere's a rather extensive documentation for download at the site. The docs for the host side mostly instruct common UNIX programming techniques: The device files are just data pipes to FIFOs in the FPGA, behaving like one would expect.
anywhere?
I removed this check because it can't happen. But the driver *does* care about this, since it creates a lot of buffers with different alignments, hence depending on the pages' alignment.+#if (PAGE_SIZE< 4096)That can never happen. Even if it does, you don't care about that in
+#error Your processor architecture has a page size smaller than 4096
+#endif
the driver.
When Xillybus is used, the whole system's mission is usually around it (e.g. it's a computer doing data acquisition through the Xillybus pipes). So giving it a high profile makes sense, I believe. Besides, a dozen of device files are not rare.
+static struct class *xillybus_class;Why not just use the misc interface instead of your own class?