Re: [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise)

[Hugh Dickins]

On Thu, 29 Nov 2012, Andrew Morton wrote:
> On Wed, 28 Nov 2012 17:22:03 -0800 (PST)
> Hugh Dickins <hughd@xxxxxxxxxx> wrote:
> 
> > +/*
> > + * llseek SEEK_DATA or SEEK_HOLE through the radix_tree.
> > + */
> > +static pgoff_t shmem_seek_hole_data(struct address_space *mapping,
> > +				    pgoff_t index, pgoff_t end, int origin)
> 
> So I was starting at this wondering what on earth "origin" is and why
> it has the fishy-in-this-context type "int".
> 
> There is a pretty well established convention that the lseek seek mode
> is called "whence".
> 
> The below gets most of it.  Too anal?

No, not too anal: I'm all in favour of "whence", which is indeed
the name of that lseek argument - since mediaeval times I believe.

It's good to have words like that in the kernel source: while you're
in the mood, please see if you can find good homes for "whither" and
"thrice" and "widdershins".

Thanks!
Hugh

> 
> 
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Subject: lseek: the "whence" argument is called "whence"
> 
> But the kernel decided to call it "origin" instead.  Fix most of the
> sites.
> 
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  fs/bad_inode.c           |    2 -
>  fs/block_dev.c           |    4 +--
>  fs/btrfs/file.c          |   16 +++++++-------
>  fs/ceph/dir.c            |    4 +--
>  fs/ceph/file.c           |    6 ++---
>  fs/cifs/cifsfs.c         |    8 +++----
>  fs/configfs/dir.c        |    4 +--
>  fs/ext3/dir.c            |    6 ++---
>  fs/ext4/dir.c            |    6 ++---
>  fs/ext4/file.c           |   22 ++++++++++----------
>  fs/fuse/file.c           |    8 +++----
>  fs/gfs2/file.c           |   10 ++++-----
>  fs/libfs.c               |    4 +--
>  fs/nfs/dir.c             |    6 ++---
>  fs/nfs/file.c            |   10 ++++-----
>  fs/ocfs2/extent_map.c    |   12 +++++------
>  fs/ocfs2/file.c          |    6 ++---
>  fs/pstore/inode.c        |    6 ++---
>  fs/read_write.c          |   40 ++++++++++++++++++-------------------
>  fs/seq_file.c            |    4 +--
>  fs/ubifs/dir.c           |    4 +--
>  include/linux/fs.h       |   12 +++++------
>  include/linux/ftrace.h   |    4 +--
>  include/linux/syscalls.h |    4 +--
>  kernel/trace/ftrace.c    |    4 +--
>  mm/shmem.c               |   20 +++++++++---------
>  26 files changed, 116 insertions(+), 116 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/