Re: [PATCH 1/1] v3.0.x: mtd: check partition count not partitionarray pointer

From: Greg KH
Date: Thu Nov 29 2012 - 16:38:30 EST


On Wed, Nov 07, 2012 at 11:48:24PM -0700, Anthony Foiani wrote:
>
> mtd: check partition count not partition array pointer
>
> The documentation claims that "nr_parts" is the determining factor,
> while the code originally tested whether "parts" is non-null.
>
> In at least one driver (fsl_elbc_nand), parts is never initialized to
> 0; even though nr_parts is correctly 0, add_mtd_partitions still tries
> to create 0 partitions.)
>
> Make the code adhere to the documentation.
>
> A quick scan of all uses in the 3.0.51 kernel show that they correctly
> rely on nr_parts rather than parts.
>
> The current kernel has retired this function; I have not examined its
> replacement to see if it has the same issue.
>
> Signed-Off-By: Anthony Foiani <anthony.foiani@xxxxxxxxx>
> ---
> drivers/mtd/mtdcore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/