Re: [PATCH 12/25] aio: Refcounting cleanup

From: Benjamin LaHaise
Date: Wed Nov 28 2012 - 20:12:18 EST


Hi Kent,

On Wed, Nov 28, 2012 at 08:43:36AM -0800, Kent Overstreet wrote:
> + * now it's safe to cancel any that need to be.
> + */
> +static void free_ioctx(struct kioctx *ctx)
...
> + aio_nr -= ctx->max_reqs;
> + spin_unlock(&aio_nr_lock);
> +
> + synchronize_rcu();
> +
> + pr_debug("freeing %p\n", ctx);
> + kmem_cache_free(kioctx_cachep, ctx);
> +}

As mentioned on irc, we probably want to avoid the synchronize_rcu()
overhead, since delays here will impact the time it takes for a task to
exit. Cheers,

-ben
--
"Thought is the essence of where you are now."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/