Re: [PATCH] mm, soft offline: split thp at the beginning of soft_offline_page()

From: Andi Kleen
Date: Tue Nov 27 2012 - 16:08:27 EST


Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> writes:

> When we try to soft-offline a thp tail page, put_page() is called on the
> tail page unthinkingly and VM_BUG_ON is triggered in put_compound_page().
> This patch splits thp before going into the main body of soft-offlining.

Looks good.

>
> The interface of soft-offlining is open for userspace, so this bug can
> lead to DoS attack and should be fixed immedately.

The interface is root only and root can do everything anyways, so it's
not really a security issue.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/