Re: [PATCH 2/2] uprobes/powerpc: Make use of generic routines toenable single step

[Suzuki K. Poulose]

On 11/26/2012 10:31 PM, Oleg Nesterov wrote:
> On 11/26, Suzuki K. Poulose wrote:
> > @@ -121,8 +125,11 @@ int arch_uprobe_post_xol(struct arch_uprobe *auprobe, struct pt_regs *regs)
> >   	 * to be executed.
> >   	 */
> >   	regs->nip = utask->vaddr + MAX_UINSN_BYTES;
> > +	regs->msr = utask->autask.saved_msr;
> > +#ifdef CONFIG_PPC_ADV_DEBUG_REGS
> > +	mtspr(SPRN_DBCR0, utask->autask.saved_dbcr);
> > +#endif
> >
> > -	user_disable_single_step(current);
>
> Don't we need the same change in arch_uprobe_abort_xol() ?
Yes, we do. Thanks for catching that. I will fix it.

Thanks for the review.

Suzuki

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/