Re: [patch 4/8] mem-hotplug selftests: print failure status insteadof cause make error

[Pekka Enberg]

On Sat, Nov 24, 2012 at 10:29 AM,  <dyoung@xxxxxxxxxx> wrote:
>   bash-4.1$ make -C memory-hotplug run_tests
>   make: Entering directory `/home/dave/git/linux-2.6/tools/testing/selftests/memory-hotplug'
>   ./on-off-test.sh
>   make: execvp: ./on-off-test.sh: Permission denied
>   make: *** [run_tests] Error 127
>   make: Leaving directory `/home/dave/git/linux-2.6/tools/testing/selftests/memory-hotplug'
>
> After applying the patch:
>   bash-4.1$ make -C memory-hotplug run_tests
>   make: Entering directory `/home/dave/git/linux-2.6/tools/testing/selftests/memory-hotplug'
>   /bin/sh: ./on-off-test.sh: Permission denied
>   memory-hotplug selftests: [FAIL]
>   make: Leaving directory `/home/dave/git/linux-2.6/tools/testing/selftests/memory-hotplug'
>
> Signed-off-by: Dave Young <dyoung@xxxxxxxxxx>

Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxx>

It'd be good if we could turn off the make produced noise to make the
output look something like this:

   bash-4.1$ make -C memory-hotplug run_tests
   /bin/sh: ./on-off-test.sh: Permission denied
   memory-hotplug selftests: [FAIL]

> ---
>  tools/testing/selftests/memory-hotplug/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.orig/tools/testing/selftests/memory-hotplug/Makefile      2012-11-23 22:37:04.869057759 +0800
> +++ linux-2.6/tools/testing/selftests/memory-hotplug/Makefile   2012-11-23 22:38:43.148525333 +0800
> @@ -1,6 +1,6 @@
>  all:
>
>  run_tests:
> -       ./on-off-test.sh
> +       @./on-off-test.sh || echo "memory-hotplug selftests: [FAIL]"
>
>  clean:
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/