Re: [PATCH] Remove inline from clock framework function definitions to buildthe kernel with GCC 4.7

From: Mike Turquette
Date: Fri Nov 16 2012 - 12:39:00 EST


Quoting Igor Mazanov (2012-11-16 09:16:02)
> Paul Walmsley wrote:
> > + Mike
> >
> > On Thu, 15 Nov 2012, Igor Mazanov wrote:
> >
> >> Remove inline from clock framework function definitions to
> >> build the kernel with GCC 4.7
> >
> > sparse warns about this also.
> >
> >> Signed-off-by: Igor Mazanov <i.mazanov@xxxxxxxxx>
> >
> > This one is for Mike to deal with as CCF maintainer; it's out of the hands
> > of the OMAP folks.
>
> Thanks for comments, I'll bear in mind it for the future.
>

I forgot to reply to this thread yesterday. A fixes request has been
sent out, hopefully will be picked up for 3.7-rc6.

Thanks all,
Mike

> >
> > Acked-by: Paul Walmsley <paul@xxxxxxxxx>
> >
> >
> >> ---
> >> include/linux/clk-provider.h | 4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> >> index c127315..f9f5e9e 100644
> >> --- a/include/linux/clk-provider.h
> >> +++ b/include/linux/clk-provider.h
> >> @@ -335,8 +335,8 @@ const char *__clk_get_name(struct clk *clk);
> >> struct clk_hw *__clk_get_hw(struct clk *clk);
> >> u8 __clk_get_num_parents(struct clk *clk);
> >> struct clk *__clk_get_parent(struct clk *clk);
> >> -inline int __clk_get_enable_count(struct clk *clk);
> >> -inline int __clk_get_prepare_count(struct clk *clk);
> >> +int __clk_get_enable_count(struct clk *clk);
> >> +int __clk_get_prepare_count(struct clk *clk);
> >> unsigned long __clk_get_rate(struct clk *clk);
> >> unsigned long __clk_get_flags(struct clk *clk);
> >> int __clk_is_enabled(struct clk *clk);
> >> --
> >> 1.7.4.4
> >>
> >
> >
> > - Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/