Re: [PATCH v4 5/7] mfd: max8925: support dt for regulator

[Qing Xu]

On 11/07/2012 10:20 PM, Mark Brown wrote:
> On Wed, Nov 07, 2012 at 06:09:53PM +0800, Qing Xu wrote:
> > From: Qing Xu <qingx@xxxxxxxxxxx>
> >
> > Signed-off-by: Qing Xu <qingx@xxxxxxxxxxx>
> Applied, thanks.
>
> > +max8925 regulator device register is still handled by mfd_add_devices, not by
> > +of_xxx, so, it is not necessary to add compatible name. Also, those reg
> > +offset and id info is stored in mfd_cell(see max8925-core.c), as a result
> > +there is not private properties in dts.
> > +node's name should match with the definition in max8925_regulator_matches
> > +(see max8925-regulator.c)
> Please submit a followup which removes all the Linux-specific references
> and just enumerates the supported regulators.  Please do also use a
> subject line appropriate for the subsystem - this is for the regulator
> driver so it should be regulator:
updated in another patch, please help me review it, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/