RE: [PATCH 6/8] pwm: pwm-tiehrpwm: Adding TBCLK gating support.

[Philip, Avinash]

On Tue, Nov 06, 2012 at 12:16:13, Bedia, Vaibhav wrote:
> On Mon, Nov 05, 2012 at 14:42:27, Philip, Avinash wrote:
> [...]
> 
> > +	/* Some platforms require explicit tbclk gating */
> > +	if (of_property_read_bool(pdev->dev.of_node, "tbclkgating")) {
> > +		pc->tbclk = clk_get(&pdev->dev, "tbclk");
> > +		if (IS_ERR(pc->tbclk)) {
> > +			dev_err(&pdev->dev, "Could not get EHRPWM TBCLK\n");
> > +			return PTR_ERR(pc->tbclk);
> > +		}
> > +	}
> > +
> > +	/* Enable tbclk & leave */
> > +	if (pc->tbclk)
> > +		clk_enable(pc->tbclk);
> > +
> 
> Here also why are you leaving this clock always running?

This is an additional clock gating for EHRPWM functional clock from
control module. The enabling of this clock to pwm_enable 
& disabling to pwm_disable. I will correct it.



Thanks
Avinash

> 
> Regards,
> Vaibhav
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/