Re: [PATCH 5/7] mfd: max8925: support dt for regulator

[Qing Xu]

On 11/06/2012 05:01 PM, Mark Brown wrote:
> On Tue, Nov 06, 2012 at 03:44:52PM +0800, Qing Xu wrote:
> > From: Qing Xu <qingx@xxxxxxxxxxx>
> >
> > Signed-off-by: Qing Xu <qingx@xxxxxxxxxxx>
> > ---
> >   drivers/regulator/max8925-regulator.c |   35 ++++++++++++++++++++++++++++++++-
> >   1 files changed, 34 insertions(+), 1 deletions(-)
> There is no binding document here, documentation is required for all new
> bindings.
>
> > +	nproot = of_find_node_by_name(nproot, "regulators");
> > +	if (!nproot) {
> > +		dev_err(&pdev->dev, "failed to find regulators node\n");
> > +		return -ENODEV;
> > +	}
> > +	for_each_child_of_node(nproot, np) {
> > +		if (!of_node_cmp(np->name, info->desc.name)) {
> > +			config->init_data =
> > +				of_get_regulator_init_data(&pdev->dev, np);
> > +			config->of_node = np;
> > +			break;
> > +		}
> > +	}
> You appear to be open coding something like the standard helpers in
> of_regulator.h, you should use those helpers.
Mark, thanks for your so quick response! I updated the patch in v2, 
please help me review it again.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/