Re: [PATCH V2 3/3] checkpatch: Emit an warning when floating pointvalues are used

[Andrew Morton]

On Thu,  1 Nov 2012 00:12:18 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> Linux kernel doesn't like floating point, say so.
> 
> ...
>
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2332,6 +2332,13 @@ sub process {
>  			     "do not add new typedefs\n" . $herecurr);
>  		}
>  
> +# check for floating point constants
> +
> +		if ($line =~ /\b$Float\b/) {
> +			WARN("KERNEL_FLOAT",
> +			     "Floating point is not supported in linux kernel source\n" . $herecurr);
> +		}
> +
>  # * goes on variable not on type
>  		# (char*[ const])
>  		while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {

The earlier review comments were not addressed.

In particular, I don't see a problem with people doing

	int foo = 1.1 * 2.2;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/