Re: [PATCH 3/3] perf report: Postpone objdump check until annotationrequested

From: David Ahern
Date: Mon Nov 05 2012 - 10:25:46 EST


On 11/1/12 11:50 PM, Namhyung Kim wrote:
From: Namhyung Kim <namhyung.kim@xxxxxxx>

David reported that current perf report refused to run on a data file
captured from a different machine because of objdump. Since the
objdump tools won't be used unless annotation was requested, checking
its presence at init time doens't make sense.

Reported-by: David Ahern <dsahern@xxxxxxxxx>
Cc: Irina Tirdea <irina.tirdea@xxxxxxxxx>
Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
---
tools/perf/builtin-report.c | 9 ++-------
tools/perf/builtin-top.c | 3 ++-
tools/perf/ui/browsers/hists.c | 22 ++++++++++++++++------
tools/perf/util/hist.h | 7 +++++--
4 files changed, 25 insertions(+), 16 deletions(-)

Reviewed-by/Tested-by: David Ahern <dsahern@xxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/