[PATCH 1/1] staging: usbip: remove an unnecessary lock in usbip_event_happened. The variable "happened" is local. So I think there is no need to lock here.

From: Harvey Yang
Date: Sun Nov 04 2012 - 23:46:28 EST


From: harvey.yang <harvey.huawei.yang@xxxxxxxxx>


Signed-off-by: harvey.yang <harvey.huawei.yang@xxxxxxxxx>
---
drivers/staging/usbip/usbip_event.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/usbip/usbip_event.c b/drivers/staging/usbip/usbip_event.c
index d332a34..668f8e0 100644
--- a/drivers/staging/usbip/usbip_event.c
+++ b/drivers/staging/usbip/usbip_event.c
@@ -116,10 +116,8 @@ int usbip_event_happened(struct usbip_device *ud)
{
int happened = 0;

- spin_lock(&ud->lock);
if (ud->event != 0)
happened = 1;
- spin_unlock(&ud->lock);

return happened;
}
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/