Re: [PATCH] atp: remove set_rx_mode_8012()

From: David Miller
Date: Sat Nov 03 2012 - 15:43:48 EST


From: Paul Bolle <pebolle@xxxxxxxxxx>
Date: Sat, 03 Nov 2012 10:53:15 +0100

> Building atp.o triggers this GCC warning:
> drivers/net/ethernet/realtek/atp.c: In function ʽset_rx_modeʼ:
> drivers/net/ethernet/realtek/atp.c:871:26: warning: ʽmc_filter[0]ʼ may be used uninitialized in this function [-Wuninitialized]
>
> GCC is correct. In promiscuous mode 'mc_filter' will be used
> uninitialized in set_rx_mode_8012(), which is apparently inlined into
> set_rx_mode().
>
> But it turns out set_rx_mode_8012() will never be called, since
> net_local.chip_type will always be RTL8002. So we can just remove
> set_rx_mode_8012() and do some related cleanups.
>
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>

Applied.
N?§²ζμrΈ?yϊθ?Ψb²X¬ΆΗ§vΨ^?)ήΊ{.nΗ+?·??{±?κηzX§Ά?ʽά¨}©?²Ζ zΪ&j:+v?¨Ύ«?κηzZ+?Κ+zf£ʼ·h??§~?­?Ϋi?ϋΰzΉ?w?ʼΈ??¨θ­Ϊ&ʼ)ίʼf?ω^jΗ«y§m?α@A«aΆΪ? 0Άμh?ε?i